L1Trigger/TrackerDTC code restructuring

[tschuh]

PR description:

I produce the class serving configuration parameter now with an ESProducer, that makes it easier for the downstream producers and analyzers to use it. I moved some functions from the DTC ed product to this es product.

PR validation:

Just building and running L1Trigger/TrackerDTC/test/test_cfg.py

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

L1Trigger/TrackerDTC/src/Settings.cc:252:11: error: no matching constructor for initialization of 'TTDTC' [clang-diagnostic-error]
    TTDTC ttDTC(numRegions_, numOverlappingRegions_, numDTCsPerRegion_);
          ^
DataFormats/L1TrackTrigger/interface/TTDTC.h:33:3: note: candidate constructor not viable: requires single argument 'setup', but 3 arguments were provided
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29824/15346

• This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29824/15346/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29824/15346/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29824/15348

• This PR adds an extra 80KB to repository

[cmsbuild]

+1
Tested at: 450eb34
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59e798/6400/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59e798/6400/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694369
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[kpedro88]

+upgrade

[silviodonato]

+operations

• update of Configuration/StandardSequences/python/L1TrackTrigger_cff.py to use the new file L1Trigger/TrackerDTC/python/ProducerED_cff.py instead of the old Producer_cff

[silviodonato]

do you have any comments @rekovic ?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1