Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code checks to the CaloOnlineTools packages #29877

Merged
merged 2 commits into from May 20, 2020
Merged

Apply code checks to the CaloOnlineTools packages #29877

merged 2 commits into from May 20, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 18, 2020

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

@fwyzard
Apply clang-tidy automated code changes
6c71ed5 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-format automated formattng changes
213c1eb
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 18, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 18, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29877/15455

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CaloOnlineTools/EcalTools

@pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@rchatter, @mmusich, @tocheng, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

It's not clear that the tests ever started.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6428/console Started: 2020/05/19 17:08

@cmsbuild
Copy link
Contributor

+1
Tested at: 213c1eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8232/6428/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be8232/6428/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694416
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

merge
alca: @pohsun @tlampen @tocheng @christopheralanwest

@cmsbuild cmsbuild merged commit fc108a4 into cms-sw:master May 20, 2020
@fwyzard fwyzard deleted the Apply_clang-format_CaloOnlineTools branch May 20, 2020 08:29
@tlampen
Copy link
Contributor

tlampen commented May 20, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fwyzard @cmsbuild @christopheralanwest @silviodonato @tlampen