Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code checks to the ElectroWeakAnalysis packages #29884

Merged
merged 4 commits into from May 20, 2020
Merged

Apply code checks to the ElectroWeakAnalysis packages #29884

merged 4 commits into from May 20, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 18, 2020

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

@fwyzard
Apply clang-tidy automated code changes
e39545a 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-tidy automated code changes
9964fb6 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-format automated formattng changes
c532323
@fwyzard
Apply clang-format automated formattng changes
81fc088
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 18, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 18, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29884/15458

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

ElectroWeakAnalysis/WMuNu
ElectroWeakAnalysis/ZMuMu

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

merge
cc: @santocch

@cmsbuild cmsbuild merged commit 9dad882 into cms-sw:master May 20, 2020
@fwyzard fwyzard deleted the Apply_clang-format_ElectroWeakAnalysis branch May 20, 2020 08:29
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-pending fully-signed orp-approved tests-started
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @silviodonato @santocch