optimize some hotspot use cases of deltaR and polar in reco/miniAOD

[slava77]

this was somewhat motivated by the report today in https://indico.cern.ch/event/921063/
More details followed from phase-2 PAT step CPU profiling https://jiwoong.web.cern.ch/jiwoong/cgi-bin/igprof-navigator/igprofCPU_CMSSW_11_1_0_pre6PAT/21

tested on data wf 136.88811 (re-miniAOD from UL) and rereco wf 136.888, showing no differences

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29918/15518

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/plugins/PATElectronProducer.cc modified in PR(s): Move EffectiveAreas and ThreadSafeFunctor classes out of EgammaTools #29832

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29918/15518/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29918/15518/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29918/15519

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/plugins/PATElectronProducer.cc modified in PR(s): Move EffectiveAreas and ThreadSafeFunctor classes out of EgammaTools #29832

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CommonTools/CandAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @JyothsnaKomaragiri, @makortel, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @ahinzmann, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6445/console Started: 2020/05/19 23:11

[slava77]

time changes on 100 events in 136.88811

138.06 ms/ev ->         9.41 ms/ev patPFMet
138.61 ms/ev ->         9.66 ms/ev patMETs
50.22 ms/ev ->         3.64 ms/ev patPFMetPuppi
50.41 ms/ev ->         3.68 ms/ev patMETsPuppi
2.10 ms/ev ->         0.76 ms/ev patElectrons
64.01 ms/ev ->        29.74 ms/ev isolatedTracks
11.91 ms/ev ->         5.74 ms/ev patMuons

[slava77]

time changes on 100 events in 136.88811

138.06 ms/ev ->         9.41 ms/ev patPFMet
138.61 ms/ev ->         9.66 ms/ev patMETs
50.22 ms/ev ->         3.64 ms/ev patPFMetPuppi
50.41 ms/ev ->         3.68 ms/ev patMETsPuppi
2.10 ms/ev ->         0.76 ms/ev patElectrons
64.01 ms/ev ->        29.74 ms/ev isolatedTracks
11.91 ms/ev ->         5.74 ms/ev patMuons

the cost in MET is new, it was introduced after 11_1_0_pre5; the rest was around for a while.

[cmsbuild]

+1
Tested at: 569cecc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dfde9/6445/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dfde9/6445/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 42
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694375
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[slava77]

+1

for #29918 569cecc

• jenkins tests passed with no differences

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1