changed boost::unordered_map for std::unordered_map in SiStripObjects

[camolezi]

PR description:

std::unordered_map and boost::unordered_map have very similar performance. So, we can reduce boost dependency by replacing boost::unordered_map for std::unordered_map.

PR validation:

Passed on basic runTheMatrix test.

I've run some benchmarks to compare boost vs std unordered_maps performance:

Map search benchmark.
https://gist.github.com/camolezi/f14800fd4c60af7d2ef501b6b92f9ddd

Adding and removing elements.
https://gist.github.com/camolezi/a5a39539a8c7252d74ec8e6f17f6aa37

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29944/15581

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibFormats/SiStripObjects/src/SiStripDelay.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

CalibFormats/SiStripObjects

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[pohsun]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6533/console Started: 2020/05/23 10:00

[cmsbuild]

+1
Tested at: ee945be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-774ee5/6533/summary.html
CMSSW: CMSSW_11_1_X_2020-05-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-774ee5/6533/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780726
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1