[DD4HEP] common and muon alignment DD4HEP migration #29952

hyunyong · 2020-05-22T13:05:48Z

PR description:
DD4HEP migration targets

/Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorAsAnalyzer.cc
/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
/Alignment/MuonAlignment/plugins/MisalignedMuonESProducer.cc
/Alignment/MuonAlignment/src/MuonAlignmentInputMethod.cc
/Alignment/MuonAlignment/src/MuonAlignmentOutputXML.cc
/Alignment/MuonAlignment/test/TestReader.cpp

Migration codes get the moun detector geometries from the event setup, so no more geometry builds on the alignment codes.
Tracker alignment parts on common alignment are modified by @adewit

Saving CommonAlignment work (does not compile currently)

…orAsAnalyzer

cmsbuild · 2020-05-22T13:06:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-22T13:12:24Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29952/15601

This PR adds an extra 84KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentMonitor/interface/AlignmentMonitorBase.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Alignment/MuonAlignment/src/MuonAlignmentInputDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Alignment/MuonAlignment/src/MuonAlignmentInputSurveyDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Alignment/MuonAlignment/src/MuonAlignmentInputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Alignment/MuonAlignment/src/MuonAlignmentOutputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Geometry/CommonTopologies/interface/GeometryAligner.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29952/15601/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29952/15601/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

mmusich · 2020-05-22T13:53:14Z

@hyunyong can you apply the required code-format patch? otherwise the PR can't be tested.

cmsbuild · 2020-05-22T14:01:29Z

The code-checks are being triggered in jenkins.

hyunyong · 2020-05-22T14:01:55Z

@hyunyong can you apply the required code-format patch? otherwise the PR can't be tested.

Yes, thank you!

cmsbuild · 2020-05-22T14:08:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29952/15602

This PR adds an extra 84KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Alignment/MuonAlignment/src/MuonAlignmentInputDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Alignment/MuonAlignment/src/MuonAlignmentInputSurveyDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Alignment/MuonAlignment/src/MuonAlignmentInputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Alignment/MuonAlignment/src/MuonAlignmentOutputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Geometry/CommonTopologies/interface/GeometryAligner.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-05-22T14:08:49Z

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/MuonAlignment
Geometry/CommonTopologies

@civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@pakhotin, @fabiocos, @adewit, @makortel, @abbiendi, @jhgoh, @VinInn, @tocheng, @tlampen, @mschrode, @mmusich, @trocino, @ebrondol this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cvuosalo · 2020-05-22T22:35:40Z

@cmsbuild please test

cmsbuild · 2020-05-22T22:36:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6531/console Started: 2020/05/23 01:22

cmsbuild · 2020-05-30T17:45:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29952/15771

This PR adds an extra 124KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Alignment/MuonAlignment/src/MuonAlignmentInputDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Alignment/MuonAlignment/src/MuonAlignmentInputSurveyDB.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Alignment/MuonAlignment/src/MuonAlignmentInputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Alignment/MuonAlignment/src/MuonAlignmentOutputXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Geometry/CommonTopologies/interface/GeometryAligner.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-05-30T17:46:15Z

Pull request #29952 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun can you please check and sign again.

christopheralanwest · 2020-05-30T17:47:34Z

please test

cmsbuild · 2020-05-30T17:48:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6709/console Started: 2020/05/30 20:47

cmsbuild · 2020-05-30T20:04:53Z

+1
Tested at: 1632ea1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af0f9/6709/summary.html
CMSSW: CMSSW_11_2_X_2020-05-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-30T20:04:55Z

Comparison job queued.

cmsbuild · 2020-05-30T21:33:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af0f9/6709/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2783662
DQMHistoTests: Total failures: 43
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2783569
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cvuosalo · 2020-06-01T21:36:00Z

+1

silviodonato · 2020-06-02T14:36:07Z

Do you have any comments? alca: @pohsun @tlampen @tocheng @christopheralanwest

pohsun · 2020-06-04T05:47:45Z

+1

cmsbuild · 2020-06-04T05:48:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-04T07:38:41Z

+1

adewit and others added 4 commits May 21, 2020 19:38

Fix

8690e08

Saving CommonAlignment work (does not compile currently)

First working attempt at modifications for CommonAlignmentProducer

a381967

Making relevant modification in CommonAlignmentMonitor/AlignmentMonit…

4f0e833

…orAsAnalyzer

DD4HEP migration for muon alignment

560d68d

cmsbuild added this to the CMSSW_11_1_X milestone May 22, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels May 22, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 22, 2020

code-format patch

b6835f2

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 22, 2020

smuzaffar modified the milestones: CMSSW_11_1_X, CMSSW_11_2_X May 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 30, 2020

cmsbuild added tests-started and removed tests-pending labels May 30, 2020

cmsbuild added tests-approved and removed tests-started labels May 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 30, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Jun 1, 2020

cmsbuild removed alca-pending pending-signatures labels Jun 4, 2020

cmsbuild added alca-approved fully-signed labels Jun 4, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 4, 2020

cmsbuild merged commit ba54a20 into cms-sw:master Jun 4, 2020

cmsbuild mentioned this pull request Jun 4, 2020

fix direct access to tau ID container #30106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4HEP] common and muon alignment DD4HEP migration #29952

[DD4HEP] common and muon alignment DD4HEP migration #29952

hyunyong commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020

hyunyong commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cvuosalo commented May 22, 2020

cmsbuild commented May 22, 2020 •

edited

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

christopheralanwest commented May 30, 2020

cmsbuild commented May 30, 2020 •

edited

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

cvuosalo commented Jun 1, 2020

silviodonato commented Jun 2, 2020

pohsun commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

silviodonato commented Jun 4, 2020

[DD4HEP] common and muon alignment DD4HEP migration #29952

[DD4HEP] common and muon alignment DD4HEP migration #29952

Conversation

hyunyong commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

mmusich commented May 22, 2020

cmsbuild commented May 22, 2020

hyunyong commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cvuosalo commented May 22, 2020

cmsbuild commented May 22, 2020 • edited

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

christopheralanwest commented May 30, 2020

cmsbuild commented May 30, 2020 • edited

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

cmsbuild commented May 30, 2020

cvuosalo commented Jun 1, 2020

silviodonato commented Jun 2, 2020

pohsun commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

silviodonato commented Jun 4, 2020

cmsbuild commented May 22, 2020 •

edited

cmsbuild commented May 30, 2020 •

edited