Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of DYT #2996

Merged
merged 56 commits into from Apr 14, 2014
Merged

new version of DYT #2996

merged 56 commits into from Apr 14, 2014

Conversation

dr4kan
Copy link
Contributor

@dr4kan dr4kan commented Mar 24, 2014

new version of DYT. Details can be found here: https://indico.cern.ch/event/295796/contribution/2/material/slides/0.pdf

The code tuning will be performed after the release of muon APEs and new local errors for DTs.

@slava77
Copy link
Contributor

slava77 commented Apr 8, 2014

+1

for #2996 dd87ecd

based on review above,
quick test of 5024d2b (compared to 01422f5 there was a change in DYTthrs: it doesn't introduce adverse changes)
and a confirmation that dd87ecd runs with jenkins.

Just for future ref, some plots made with 5024d2b using 1TeV muon sample, comparing with the baseline:

  • better peak in pt
    all_5024d2bvsorig_singlemupt1000wf22p0c_log10recotracks_tevmuons_dyt_reco_obj_pt
  • smaller tail in chi2 (all just goes into the core)
    all_5024d2bvsorig_singlemupt1000wf22p0c_minrecotracks_tevmuons_dyt_reco_obj_normalizedchi2 29

@dr4kan
Copy link
Contributor Author

dr4kan commented Apr 14, 2014

@apfeiffer1, @diguida, @thspeer, @rcastello, @slava77, @ggovi, @Degano

Hi, there are still two pending signatures since many days. As the deadline for pre7 is today can you please take a look at this PR and eventually sign it.
Thanks.

@apfeiffer1
Copy link
Contributor

+1
sorry for the delay - I somehow missed that one.

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 14, 2014
@ktf ktf merged commit 2d25662 into cms-sw:CMSSW_7_1_X Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants