Add safety check to spot negative jet energy correction factors

[ahinzmann]

PR description:

Add a safety check when evaluating jet energy correction factors to spot cases where the functions yield unphysical negative corrections.
A warning is printed and the value is truncated to be small positive.
This should help spotting cases when calibration functions in the conditions are not fully positive defined (as they should).

PR validation:

runTheMatrix -l limited

if this PR is a backport please specify the original PR and why you need to backport that PR:

To all release down to 10_6 to protect UL/Run3/Phase-2 studies.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29994/15668

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29994/15669

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #29994 was updated. @ggovi, @cmsbuild, @santocch can you please check and sign again.

[santocch]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6626/console Started: 2020/05/27 22:32

[cmsbuild]

+1
Tested at: bf296e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-957fe7/6626/summary.html
CMSSW: CMSSW_11_2_X_2020-05-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-957fe7/6626/summary.html

Comparison Summary:

• You potentially added 375 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 45
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780697
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[silviodonato]

Do you have any comments? @ggovi

[silviodonato]

@ggovi Do you have any comments?

[silviodonato]

merge
cc: @ggovi