Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in PSetBlobProducer functionality for use in HLT (11_1_X) #29999

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Fixes in PSetBlobProducer functionality for use in HLT (11_1_X)

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

#29998
Needed for use in 11_1.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_11_1_X.

It involves the following packages:

EventFilter/Utilities
IOPool/Streamer

@perrotta, @smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @slava77, @mommsen can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #29998

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6612/console Started: 2020/05/27 14:01

@Martin-Grunewald
Copy link
Contributor Author

abort test

@cmsbuild
Copy link
Contributor

Pull request #29999 was updated. @perrotta, @smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @slava77, @mommsen can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

-1

Tested at: 043e3b5

CMSSW: CMSSW_11_1_X_2020-05-27-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa150/6612/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test BUFU_TEST had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6618/console Started: 2020/05/27 15:59

@cmsbuild
Copy link
Contributor

+1
Tested at: 514b10b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa150/6618/summary.html
CMSSW: CMSSW_11_1_X_2020-05-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa150/6618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@makortel
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented May 27, 2020

+1

for #29999 043e3b5

  • changes are the same as in the master version

@mommsen
Copy link
Contributor

mommsen commented May 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0969d4a into cms-sw:CMSSW_11_1_X May 28, 2020
@Martin-Grunewald Martin-Grunewald deleted the FixesForPSetBlobProducerIn11 branch October 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants