Improve friendly class names of unordered_set and unordered_map #30004
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30004/15688
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
…_set and std::unordered_map
makortel
force-pushed
the
friendlyNameUnorderedMap2
branch
from
987093a
to
884fce2
Compare
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30004/15689
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Utilities @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@Dr15Jones please review |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30004/15750
|
|
Pull request #30004 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
This PR is a follow-up to #29987 to handle the default
HashandKeyEqualtemplate arguments (they get ignored for the friendly class name), and also customHashtemplate argument. Resolves #29967.PR validation:
Unit test runs.