New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix one more CondCore unit test #30008
Conversation
type bug-fix |
The code-checks are being triggered in jenkins. |
@cmsbuild, please test for CMSSW_11_2_PY3_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30008/15698
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/Utilities @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison is ready Comparison Summary:
|
Do you have any comments? @ggovi |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Resolves #29983
PR description:
Addresses issue raised at #29983 (comment).
I profit of this PR (in commit 8612e67) also to fix the test
CondCore/Utilities/test/testPngHistograms.cpp
which was actually not doing anything useful.PR validation:
Relies on the existing unit tests, both in
CMSSW_11_2_X_2020-05-27-2300
andCMSSW_11_2_PY3_X_2020-05-27-2300
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, and no backport are needed.