Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one more CondCore unit test #30008

Merged
merged 2 commits into from Jun 2, 2020
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 28, 2020

Resolves #29983

PR description:

Addresses issue raised at #29983 (comment).
I profit of this PR (in commit 8612e67) also to fix the test CondCore/Utilities/test/testPngHistograms.cpp which was actually not doing anything useful.

PR validation:

Relies on the existing unit tests, both in CMSSW_11_2_X_2020-05-27-2300 and CMSSW_11_2_PY3_X_2020-05-27-2300

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no backport are needed.

@mmusich
Copy link
Contributor Author

mmusich commented May 28, 2020

type bug-fix

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented May 28, 2020

@cmsbuild, please test for CMSSW_11_2_PY3_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30008/15698

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 8612e67
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d201f/6641/summary.html
CMSSW: CMSSW_11_2_PY3_X_2020-05-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d201f/6641/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4230 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2782372
  • DQMHistoTests: Total failures: 742
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2781630
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

Do you have any comments? @ggovi

@ggovi
Copy link
Contributor

ggovi commented Jun 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b1f295 into cms-sw:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CondCore unit tests failing for PY3 IBs due to use of boost_python
4 participants