[GEOMETRY] fixes UBSAN build errors #30021

smuzaffar · 2020-05-28T17:03:10Z

Fixes for UBSAN IBs build errors

https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc820/www/fri/11.2.UBSAN-fri-23/CMSSW_11_2_UBSAN_X_2020-05-22-2300

cmsbuild · 2020-05-28T17:03:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-28T17:09:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30021/15713

This PR adds an extra 16KB to repository

cmsbuild · 2020-05-28T17:10:14Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-05-28T17:10:57Z

please test

cmsbuild · 2020-05-28T17:11:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6656/console Started: 2020/05/28 19:13

cmsbuild · 2020-05-28T18:25:48Z

+1
Tested at: e811fba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48b178/6656/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-28T18:25:50Z

Comparison job queued.

ianna · 2020-05-28T19:57:28Z

+1

cmsbuild · 2020-05-28T19:57:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-05-28T20:02:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48b178/6656/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780740
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cvuosalo · 2020-05-28T20:46:48Z

Geometry/HcalTowerAlgo/test/HcalCellParameterDump.cc

  int subdet_;
 };

 HcalCellParameterDump::HcalCellParameterDump(const edm::ParameterSet& iConfig) {
-  subdet_ = std::min(detMax_, std::max(iConfig.getParameter<int>("SubDetector"), 1));
-  subdet_ = std::min(detMax_, std::max(subdet_, 1));
+  subdet_ = std::min(HcalCellParameterDump::detMax_, std::max(iConfig.getParameter<int>("SubDetector"), 1));


@smuzaffar Why is the HcalCellParameterDump:: qualification necessary? There is no other detMax_ that could cause confusion, and the constructor certainly has access to its own data members.

you are right @cvuosalo , I started with adding the namespace but then it turned out the constexpr should fix the issue. I have updated the PR

cmsbuild · 2020-05-28T22:20:40Z

The code-checks are being triggered in jenkins.

smuzaffar · 2020-05-28T22:22:02Z

please test

cmsbuild · 2020-05-28T22:26:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30021/15738

This PR adds an extra 16KB to repository

cmsbuild · 2020-05-28T22:26:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6675/console Started: 2020/05/29 00:42

cmsbuild · 2020-05-28T22:26:51Z

Pull request #30021 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

cmsbuild · 2020-05-28T23:53:46Z

+1
Tested at: e3bddd9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48b178/6675/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-28T23:53:48Z

Comparison job queued.

cmsbuild · 2020-05-29T03:48:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48b178/6675/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 72
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780670
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cvuosalo · 2020-05-29T19:14:40Z

+1

cmsbuild · 2020-05-29T19:15:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-30T07:34:36Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone May 28, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels May 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2020

cmsbuild added tests-started and removed tests-pending labels May 28, 2020

cmsbuild added tests-approved and removed tests-started labels May 28, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels May 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 28, 2020

cvuosalo reviewed May 28, 2020

View reviewed changes

cmsbuild added comparison-pending geometry-pending pending-signatures tests-pending labels May 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2020

cmsbuild added tests-started and removed tests-pending labels May 28, 2020

cmsbuild added tests-approved and removed tests-started labels May 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 29, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels May 29, 2020

cmsbuild added orp-approved and removed orp-pending labels May 30, 2020

cmsbuild merged commit 6e79c3d into cms-sw:master May 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GEOMETRY] fixes UBSAN build errors #30021

[GEOMETRY] fixes UBSAN build errors #30021

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

ianna commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cvuosalo May 28, 2020

smuzaffar May 28, 2020

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 29, 2020

cvuosalo commented May 29, 2020

cmsbuild commented May 29, 2020

silviodonato commented May 30, 2020

[GEOMETRY] fixes UBSAN build errors #30021

[GEOMETRY] fixes UBSAN build errors #30021

Conversation

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020 • edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

ianna commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cvuosalo May 28, 2020

Choose a reason for hiding this comment

smuzaffar May 28, 2020

Choose a reason for hiding this comment

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020 • edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 29, 2020

cvuosalo commented May 29, 2020

cmsbuild commented May 29, 2020

silviodonato commented May 30, 2020

cmsbuild commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020 •

edited