Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize FileBlob data members #30050

Merged
merged 1 commit into from Jun 2, 2020
Merged

Initialize FileBlob data members #30050

merged 1 commit into from Jun 2, 2020

Conversation

smuzaffar
Copy link
Contributor

testSerializationCommon iunit tests fails for AARCH64 and CLANG IBs [a]. This change initialize the data member of FileBlob class which should fix this unit test.

This fixes cms-sw/cmsdist#5685
This fixes #21002

[a]

===== Test "testSerializationCommon" ====
Serializing 10ConfObject ...
Deserializing 10ConfObject ...
Serializing 15DropBoxMetadata ...
Deserializing 15DropBoxMetadata ...
Serializing N15DropBoxMetadata10ParametersE ...
Deserializing N15DropBoxMetadata10ParametersE ...
Serializing 8FileBlob ...
Deserializing 8FileBlob ...
terminate called after throwing an instance of 'eos::portable_archive_exception'
  what():  requested integer size exceeds type size: -64
/bin/sh: line 1:  7584 Aborted                 testSerializationCommon

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar smuzaffar changed the title Intialize FileBlob data members Initialize FileBlob data members May 29, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30050/15758

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/Common

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6698/console Started: 2020/05/29 22:39

@cmsbuild
Copy link
Contributor

+1
Tested at: 06cc6c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33d866/6698/summary.html
CMSSW: CMSSW_11_2_X_2020-05-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33d866/6698/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780725
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@pohsun
Copy link

pohsun commented May 30, 2020

+1

@smuzaffar
Copy link
Contributor Author

@ggovi , can you please review this?

@smuzaffar
Copy link
Contributor Author

@ggovi , can you please check and sign this?

@ggovi
Copy link
Contributor

ggovi commented Jun 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e34b5f4 into cms-sw:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost 1.72 and CLANG/AARCH64 IB unit test Test testSerializationCommon fails in clang IBs
5 participants