Fix bug affecting boosted tau isolation (10_6_X)

[mbluj]

PR description:

This PR fixes a bug affecting indexing jet-constituent-maps. In the result of the bug constituents of a subjet nearby a considered tau - a seed of a nearby tau candidate - are not excluded from particles used to compute isolation of the tau, which breaks the boosted tau algorithm. The bug has been introduced in #17087 (for 90X) speeding up boosted tau seed producer code. Unfortunately the bug was discovered only recently by users (*).
In addition to the bug fix, in this PR we remove remnants of previous implementation changed by #17087 and improve code formatting.

Expected changes: boosted taus (in MiniAOD), especially those with other tau candidate within R<0.5, are more isolated. This will recover state from before #17087 as shown in the figure attached to #30064.

Backport of #30064 to 10_6_X. Some additional details therein.

PR validation:

Tested with the standard miniAOD workflow.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30064

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix bug affecting boosted tau isolation #30064

[slava77]

@mbluj
please update the PR title ("ix" -> "fix").

Do I understand correctly that this update is violating the no-change policy?
(or is the modified code enabled only on analysis jobs running on miniAOD)
If the regular miniAOD production is affected, please update to use run_miniAOD_devel

[mbluj]

@mbluj
please update the PR title ("ix" -> "fix").

Do I understand correctly that this update is violating the no-change policy?
(or is the modified code enabled only on analysis jobs running on miniAOD)
If the regular miniAOD production is affected, please update to use run_miniAOD_devel

Hmm, yes, it changes isolationCandidates of boosted taus and their isolation-related tauIDs, but not taus itself. In this sense this breaks compatibility with already produced 106X miniAOD samples. It is a bit strange to introduce a configuration parameter with switches on/off a bug, but of course I will introduce it.

[perrotta]

backport of #30064

[mbluj]

Adding @abdollah110 who found the bug.

[cmsbuild]

Pull request #30066 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[mbluj]

@Slava: a flag enabling/disabling fixed behaviour of the boosted tau seeding is added in the most recent commit. Please consider to add this fix to the list of UL reMiniAOD features.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6739/console Started: 2020/06/02 16:07

[cmsbuild]

+1
Tested at: 0b51527
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188443/6739/summary.html
CMSSW: CMSSW_10_6_X_2020-06-02-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188443/6739/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211971
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

Pull request #30066 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6769/console Started: 2020/06/03 14:55

[cmsbuild]

+1
Tested at: c018fb4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188443/6769/summary.html
CMSSW: CMSSW_10_6_X_2020-06-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188443/6769/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211971
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• The fix acts as it should, following the PR description and the intention behind the original code
• The update differs from the one submitted in the master because:
  • in this backport the fix is only applied depending on the run_miniAOD_devel modifier
  • it includes the code format changes applied in the meanwhile, and the bug fix Fix BoostedTauSeedsProducer.cc by replacing jetConstituent instead of pfCandidate in a LogWarning #26888 (only affecting the text output of some logWarning, otherwise buggy, and not the reco outputs)
• Jenkins tests pass and show no differences for the standard workflows, as it should

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1