New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduced boost use in PhysicsTools/Utilities #30067
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30067/15793
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: PhysicsTools/Utilities @cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 062059d CMSSW: CMSSW_11_2_X_2020-06-01-2300 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation error while trying to compile with clang. Command used:
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/test/testPrimitive.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/test/testLumiReweight.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/test/testRunner.cpp In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/test/testSimplifications.cc:2: In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/interface/Simplify.h:12: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/interface/Factorize.h:48:27: error: non-local lambda expression cannot have a capture-default static const int p = [&] { ^ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/test/testFunctionsIO.cc:6: In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/interface/Simplify.h:12: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-01-2300/src/PhysicsTools/Utilities/interface/Factorize.h:48:27: error: non-local lambda expression cannot have a capture-default |
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
062059d
to
205b9c9
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30067/15805
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replaced boost library use for C++ STL alternatives. All the code should behave identically.
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6