skip complicated checks for PFCandidate-on-PFCandidate TopProjector

[slava77]

another case of CPU optimization/minimization from PU200 hotspots
https://jiwoong.web.cern.ch/jiwoong/cgi-bin/igprof-navigator/igprofCPU_CMSSW_11_1_0_pre8PAT/16

TopProjector matching collections of PFCandidate-on-PFCandidate by Ptr can now check for just the available pointer value, without navigating deep to the parent pointers. This is enabled for pfNoPileUp*. Other cases can possibly be made from different collections where the deeper matching may be useful.

Time spent in pfNoPileUpJMENoHF and pfNoPileUpIsoPFBRECO goes down by about a factor of 10, or 19% of the miniAOD step in wf 23434.21 (PU200 ttbar) relative to a separate improvement in #30054 .
The impact is small for Run2/3 (perhaps up to 4% for "nominal" pileup cases).

tests were limited to the miniAOD wf with PU.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30071/15798

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CommonTools/ParticleFlow/plugins/TopProjector.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6723/console Started: 2020/06/02 06:44

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CommonTools/ParticleFlow

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @riga, @cbernet, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: b0b0552
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87c83b/6723/summary.html
CMSSW: CMSSW_11_2_X_2020-06-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87c83b/6723/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783666
• DQMHistoTests: Total failures: 92
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2783524
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

@smuzaffar
I was trying to navigate in the relmon to the differences
e.g. in the following
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-06-01-2300+87c83b/36744/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/Physics_Top.html
the summary shows 3 failures in comparisons in SingleTopElectronMediumDQM_miniAOD subdirectory,
but the link shown comes up with "There are no changes in this directory, nothing to be shown or navigated to. "
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-06-01-2300+87c83b/36744/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/Physics_Top_SingleTopElectronMediumDQM_miniAOD.html
Did the bot scripts end up pruning the directories too much?

DQM bin-to-bin confirms that there are actual differences
https://tinyurl.com/yczuod7o

[smuzaffar]

@slava77 , this looks strange. I am re-running the comparison job to see if it fails in the same way.

[slava77]

@cmsbuild please test with #30164

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #30164
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6981/console Started: 2020/06/12 09:52

[cmsbuild]

+1
Tested at: 4f3068e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bb31f/6981/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bb31f/6981/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2779433
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2779382
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+1

[slava77]

+1

for #30071 4f3068e

• updated to remove MassReplace.py changes in lieu of Make mass replace work with proxy types #30164 (now merged)
• jenkins tests confirmed there are no differences in comparisons

[slava77]

@santocch
please check or sign this PR for analysis
Thank you.

@silviodonato
please check if this can be merged without the analysis signature if it takes some time.
Thank you.

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1