Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEM to MuonRecoAnalyzer #30096

Merged

Conversation

seungjin-yang
Copy link
Contributor

PR description:

Add a plot about the number of valid GEM hits of the global muon for GEM Offline DQM. DT/CSC-version of the plot is already included.

PR validation:

This PR was tested with workflow 11611.0 and 27411.0.

Plots can be found on page 2 of the following link.
https://indico.cern.ch/event/924681/contributions/3885765/attachments/2049065/3436092/GEM_DPG_200601_Offline_DQM.pdf

@jshlee

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30096/15837

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

DQMOffline/Muon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @bellan, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 3, 2020

@seungjin-yang we don't have you identified as GEM DQM developer. Can you plase addyourself with your git username to the corresponding e-group?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#GEM
Thanks in advance

@jshlee
Copy link
Contributor

jshlee commented Jun 3, 2020

@jfernan2 - I will add @seungjin-yang to this

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 3, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6777/console Started: 2020/06/03 18:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+1
Tested at: 140dafc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12e2b2/6777/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12e2b2/6777/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783666
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783612
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.689 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.080 KiB Muons_miniAOD/MuonRecoAnalyzer
  • DQMHistoSizes: changed ( 11634.0,... ): 0.072 KiB Muons/MuonRecoAnalyzer
  • DQMHistoSizes: changed ( 20034.0,... ): 0.143 KiB Muons_miniAOD/MuonRecoAnalyzer
  • DQMHistoSizes: changed ( 20034.0,... ): 0.135 KiB Muons/MuonRecoAnalyzer
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce4efc7 into cms-sw:master Jun 4, 2020
@seungjin-yang seungjin-yang deleted the GEM-MuonRecoAnalyzer-from-CMSSW_11_1_0_pre8 branch June 29, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants