Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed boost dependency in RecoLocalMuon/DTSegment #30110

Merged
merged 1 commit into from Jun 6, 2020

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented Jun 4, 2020

PR description:

Replaced boost library use for C++ STL alternatives. All the code should have similar behavior.

Notes:

  • std::unordered_set demands a hasher class(TriedPattern::HashFunction) for custom classes as keys.

  • hash_combine is the same implementation as in boost::hash_combine.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30110/15874

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

RecoLocalMuon/DTSegment

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6822/console Started: 2020/06/04 19:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+1
Tested at: 3f16ad6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04557/6822/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04557/6822/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783960
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783868
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2020

+1

  • Technical (although not trivial: reviewing this PR was a good gym to learn the differences betweed std::unordered_set and boost::unordered_set)
  • Jenkinst tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7ba35a7 into cms-sw:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants