make DetStatus a stream module

[mmusich]

PR description:

Somewhat inspired by issue #25090 I realize this module can become a edm::stream::EDFilter.
Profited to add also fillDescriptions method and to move everything into the cc file.

PR validation:

Tested in CMSSW_11_2_X_2020-06-04-1100 with concurrent lumisection workflows:

runTheMatrix.py -l 136.8861,136.8862 -j 8 -t 4 --ibeos

it passes the tests and in the step3 log the message:

The following modules require synchronizing on LuminosityBlock boundaries:
  DetStatus ALCARECOTkAlMinBiasDCSFilter

is gone.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30124/15897

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DPGAnalysis/Skims/src/DetStatus.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DPGAnalysis/Skims

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6843/console Started: 2020/06/05 20:47

[cmsbuild]

+1
Tested at: e47adf7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d7d59/6843/summary.html
CMSSW: CMSSW_11_2_X_2020-06-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d7d59/6843/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780431
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[mmusich]

@chayanit, @wajidalikhan, @pgunnell

do you have comments on this PR?

[chayanit]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1