Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4 hyperon physics initialisation #30134

Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jun 7, 2020

PR description:

In order to use inside CMSSW Geant4 10.6 and master version of Geant4 simultaneously, the initialisation of hyperon hadronic physics should be changed. This modification should not affect mainstream SIM production.

PR validation:

local

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Jun 7, 2020

@bsunanda , this PR should resolve the problem with 10.6ref05.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30134/15916

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Jun 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6858/console Started: 2020/06/07 13:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+1
Tested at: 7f6745c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd6910/6858/summary.html
CMSSW: CMSSW_11_2_X_2020-06-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd6910/6858/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780443
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Jun 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b0ecb3 into cms-sw:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants