New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced boost for standard alternatives in PhysicsTools/Utilities #30137
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30137/15921
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
49cbdfd
to
79ce506
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30137/15922
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: PhysicsTools/Utilities @cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
79ce506
to
65eda09
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30137/15923
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replaced boost library use for C++ STL alternatives. The code should have similar behavior.
Also removed some includes that were unused.
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6