Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

silviodonato · 2020-06-11T13:32:52Z

After #30150, the default values of GenTtbarCategorizer are defined using fillDescriptions.
This PR delete the old GenTtbarCategorizer_cfi.py
#30150 (comment)

silviodonato · 2020-06-11T13:33:14Z

please test

cmsbuild · 2020-06-11T13:33:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-11T13:37:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30193/16027

This PR adds an extra 8KB to repository

cmsbuild · 2020-06-11T13:37:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6958/console Started: 2020/06/11 15:38

cmsbuild · 2020-06-11T13:37:48Z

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

TopQuarkAnalysis/TopTools

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-06-11T13:47:04Z

-1

Tested at: 9e8ac25

CMSSW: CMSSW_11_2_X_2020-06-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Hcal calibration cache #30060 @igv4321: Hcal calibration cache
[DB] Fixes needed for GCC 10 #30175 @smuzaffar: [DB] Fixes needed for GCC 10
[ALCA] Fixes needed for GCC 10 #30172 @smuzaffar: [ALCA] Fixes needed for GCC 10
[FASTSIM] Fixes needed for GCC 10 #30173 @smuzaffar: [FASTSIM] Fixes needed for GCC 10
adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995 @mkirsano: adapt Pythia8Interface to pythia8 302 (PR cmsdist RPC DQM - Moving to DQMEDHarvesters #5869, to be tested together)

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/6958/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/6958/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/6958/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/PTFilterHook.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/Py8InterfaceBase.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/ResonanceDecayFilterHook.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc: In constructor 'BiasedTauDecayer::BiasedTauDecayer(const Pythia8::Info*, Pythia8::Settings*, Pythia8::ParticleData*, Pythia8::Rndm*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:14:16: error: no matching function for call to 'Pythia8::TauDecays::init()'
   decayer.init();
                ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/ParticleDecays.h:21,
                 from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/HadronLevel.h:25,
                 from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/Pythia.h:24,

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/EmissionVetoHook1.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:46:
/cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:222:1: error: reference to 'EvtGenDecays' is ambiguous
EvtGenDecays::EvtGenDecays(Pythia *pythiaPtrIn, string decayFile,
^
/cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
class EvtGenDecays {
      ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Hcal calibration cache #30060 @igv4321: Hcal calibration cache
[DB] Fixes needed for GCC 10 #30175 @smuzaffar: [DB] Fixes needed for GCC 10
[ALCA] Fixes needed for GCC 10 #30172 @smuzaffar: [ALCA] Fixes needed for GCC 10
[FASTSIM] Fixes needed for GCC 10 #30173 @smuzaffar: [FASTSIM] Fixes needed for GCC 10
adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995 @mkirsano: adapt Pythia8Interface to pythia8 302 (PR cmsdist RPC DQM - Moving to DQMEDHarvesters #5869, to be tested together)

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/6958/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/6958/git-merge-result

cmsbuild · 2020-06-11T13:47:07Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

smuzaffar · 2020-06-14T12:18:02Z

please test

cmsbuild · 2020-06-14T12:18:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-14-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7049/console Started: 2020/06/14 14:43

cmsbuild · 2020-06-14T13:55:54Z

-1

Tested at: 9e8ac25

CMSSW: CMSSW_11_2_X_2020-06-14-0000
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77deca/7049/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step6

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step6_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10024.0 step6

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step5

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

cmsbuild · 2020-06-14T13:55:56Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription)

9e8ac25

cmsbuild added this to the CMSSW_11_2_X milestone Jun 11, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jun 11, 2020

silviodonato mentioned this pull request Jun 11, 2020

Modernized GenTtbarCategorizer #30150

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 11, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 11, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 11, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 14, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 14, 2020

silviodonato closed this Jun 17, 2020

silviodonato deleted the delGenTtbarCategorizer_cfi branch June 17, 2020 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

silviodonato commented Jun 11, 2020

silviodonato commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020 •

edited

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

smuzaffar commented Jun 14, 2020

cmsbuild commented Jun 14, 2020 •

edited

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

Conversation

silviodonato commented Jun 11, 2020

silviodonato commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020 • edited

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

smuzaffar commented Jun 14, 2020

cmsbuild commented Jun 14, 2020 • edited

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 11, 2020 •

edited

cmsbuild commented Jun 14, 2020 •

edited