New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing dependencies to DataFormats/EgammaTrackReco #30210
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30210/16068
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DataFormats/EgammaTrackReco @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
On Jun 12, 2020, at 2:51 PM, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
A new Pull Request was created by @davidlange6<https://github.com/davidlange6> (David Lange) for master.
It involves the following packages:
DataFormats/EgammaTrackReco
@perrotta<https://github.com/perrotta>, @cmsbuild<https://github.com/cmsbuild>, @slava77<https://github.com/slava77> can you please review it and eventually sign? Thanks.
@rovere<https://github.com/rovere> this is something you requested to watch as well.
@silviodonato<https://github.com/silviodonato>, @dpiparo<https://github.com/dpiparo> you are the release manager for this.
cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#30210 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ3YBUILRJ2BQUFMCE3RWIQGPANCNFSM4N4JP2DA>.
|
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Modules IB shows errors due to missing DataFormats/CaloRecHit dependency in DataFormats/EgammaTrackReco. I've added that and the other missing dependencies.