Generate 2021 Scenario Automatically

[ianna]

PR description:

Similar to 2026 scenarios, 2021 scenario is autogenerated by a script.

python ./Configuration/Geometry/scripts/generate2021Geometry.py

@fabiocos , could you, please, check if eras and modifies are correctly defined

• produce a dd4hep 2021 scenario from the same script

• add PPS in the CTPPS section

• add automated validation to check if the 2021 scenario was modified by hand

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30214/16079

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Update DD4hep 2021 Scenario #30208

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@ianna this is great. Since there are only some minor changes in generate2021Geometry.py compared to generate2026Geometry.py, maybe it's worth trying to unify these scripts? I can look at this if you want.

Also, it might be nice to update Configuration/Geometry/README.md with info about the 2021 geometry.

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

@ianna this is great. Since there are only some minor changes in generate2021Geometry.py compared to generate2026Geometry.py, maybe it's worth trying to unify these scripts? I can look at this if you want.

Also, it might be nice to update Configuration/Geometry/README.md with info about the 2021 geometry.

I'd appreciate if you take it from my hands. Thanks!
There is a catch though - 2021 dd4hep scenario is slightly different :-)

[ianna]

@kpedro88 - also, if you'd like to keep "D" in the file name, there will be wide-spread changes in configurations across the whole CMSSW :-(

[kpedro88]

We can make the "D" depend on the 2021 vs. 2026 settings.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30214/16083

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Update DD4hep 2021 Scenario #30208

[kpedro88]

Indeed, part of my motivation is to be able to reuse the 2021 dd4hep setup for 2026

[cmsbuild]

Pull request #30214 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[cvuosalo]

@ianna @mundim How does this PR affect the work Luiz is doing to include the PPS simulation geometry?

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30214/16144

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Update DD4hep 2021 Scenario #30208
  • File Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py modified in PR(s): PPS Full simulation integration #29916

[cmsbuild]

Pull request #30214 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[fabiocos]

@ianna if the purpose is to generate a DD4hep full configuration, the dd4hep process modifier should also be activated

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7082/console Started: 2020/06/15 18:19

[cmsbuild]

+1
Tested at: 8de1ef2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bee25/7082/summary.html
CMSSW: CMSSW_11_2_X_2020-06-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bee25/7082/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778757
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade
I'll submit a followup PR to unify the scripts, haven't had time yet

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1