Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase of relocateLorentzAngleDB #3022

Merged

Conversation

hidaspal
Copy link
Contributor

Rebase of relocateSiPixelLorentzAngleDB2CondTools. Replacing pull request #2982. It is the same stuff. It was necessary because of parallel development, relocating some files.

@hidaspal
Copy link
Contributor Author

It is based on CMSSW_7_1_X_2014-03-25-0200.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hidaspal for CMSSW_7_1_X.

rebase of relocateLorentzAngleDB

It involves the following packages:

CalibTracker/SiPixelLorentzAngle
CondTools/SiPixel

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
@venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Compiling python modules python
>> Compiling python modules src/CondTools/SiPixel/python
>> Compiling python modules src/CalibTracker/SiPixelLorentzAngle/python
>> All python modules compiled
>> Pluging of all type refreshed.
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-25-1400'


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3022/669/summary.html

@hidaspal
Copy link
Contributor Author

Sorry for that BuildFile, I did not dare to remove it. It seemed, it caused no harm, only a message. Now removed, no message.

@cmsbuild
Copy link
Contributor

Pull request #3022 was updated. @apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Mar 27, 2014

+1

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Mar 27, 2014

@nclopezo: also for this case.

@apfeiffer1
Copy link
Contributor

+1
looks OK from my side

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 28, 2014
…eader

SiPixelLorentzAngle -- rebase of relocateLorentzAngleDB
@nclopezo nclopezo merged commit ae098a9 into cms-sw:CMSSW_7_1_X Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants