Add muon ID selectors for packed candidate collections #30253

stahlleiton · 2020-06-15T20:52:26Z

PR description:

This PR adds muon ID selectors (isTrackerMuon and TMOneStationTight), as PackedCandidateRefVectors, associated the packedPFCandidates and lostTracks collections.

These are part of the HIN developments for MiniAOD event content.

Running over ~1000 events from the HIDoubleMuon PD of 2018 PbPb data, the average compressed size of the output collections (PackedCandidateRefVectors) were ~9 bytes/event for packedPFCandidates and ~6 bytes/event for lostTracks.

PR validation:

Tested with workflow 159

if this PR is a backport please specify the original PR and why you need to backport that PR:

@mandrenguyen

cmsbuild · 2020-06-15T20:52:48Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-15T20:57:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30253/16154

This PR adds an extra 20KB to repository

cmsbuild · 2020-06-15T20:58:19Z

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

jpata · 2020-06-15T21:32:32Z

PhysicsTools/PatAlgos/plugins/PackedCandidateMuonSelectorProducer.cc

+      // check if candidate and muon are compatible
+      const auto& candTrack = cand->pseudoTrack();
+      if (muonTrack.charge() == candTrack.charge() && muonTrack.numberOfValidHits() == candTrack.numberOfValidHits() &&
+          std::abs(muonTrack.eta() - candTrack.eta()) < 1E-3 && std::abs(muonTrack.phi() - candTrack.phi()) < 1E-3 &&


Is this phi subtraction safe in case of wraparound? I think one might also use a deltaR method from the framework: https://github.com/cms-sw/cmssw/blob/master/DataFormats/Math/interface/deltaR.h
In addition, perhaps it can be considered to put these cutoffs 1E-3, 1E-2 at the top of the file as a static const, or otherwise as a configurable parameter in a visible spot?

Thanks for the suggestions. I replaced the deltaPhi and deltaEta for a deltaR, and changed the cutoffs to be configurable parameters.

santocch · 2020-06-17T06:45:29Z

please test

cmsbuild · 2020-06-17T06:45:52Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7124/console Started: 2020/06/17 09:04

cmsbuild · 2020-06-17T08:27:08Z

+1
Tested at: f8e85bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-423326/7124/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-17T08:27:11Z

Comparison job queued.

cmsbuild · 2020-06-17T10:28:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-423326/7124/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild · 2020-07-01T14:45:35Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 140.5611
CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7558/console Started: 2020/07/01 16:48

cmsbuild · 2020-07-01T16:19:42Z

+1
Tested at: 68a6b85
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-423326/7558/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T16:19:45Z

Comparison job queued.

cmsbuild · 2020-07-01T18:11:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-423326/7558/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

slava77 · 2020-07-03T00:55:30Z

+1

for #30253 68a6b85

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show differences in the new products of the HI reminiAOD workflow, as expected

santocch · 2020-07-03T13:55:05Z

+1

cmsbuild · 2020-07-03T13:55:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

slava77 · 2020-07-03T19:00:57Z

@silviodonato
please check this PR.
Merging it would help to disentangle from the overlap in #30313

silviodonato · 2020-07-03T19:05:12Z

+1

Andre Govinda Stahl Leiton added 2 commits June 15, 2020 21:08

Add muon ID selectors for packed candidate collections

c6b7593

Implement code quality checks

f8e85bd

cmsbuild added this to the CMSSW_11_2_X milestone Jun 15, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 15, 2020

jpata reviewed Jun 15, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jun 17, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 17, 2020

cmsbuild mentioned this pull request Jun 19, 2020

Add Pixel Tracks in Heavy Ions MiniAOD #30313

Merged

Added deltaR and configurable matching thresholds

3f38862

cmsbuild removed the code-checks-approved label Jun 21, 2020

cmsbuild added comparison-pending tests-pending labels Jul 1, 2020

cmsbuild added tests-started and removed requires-external tests-pending labels Jul 1, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 3, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Jul 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 3, 2020

cmsbuild merged commit 7fdba2f into cms-sw:master Jul 3, 2020

stahlleiton deleted the PackedCandidateMuonID_112X_MiniAOD branch July 4, 2020 09:12

slava77 mentioned this pull request Jul 7, 2020

reco comparisons: plots for JPT jets; packed candidates from heavy ion miniAOD cms-sw/cms-bot#1340

Merged

stahlleiton mentioned this pull request Oct 1, 2020

Bugfix for PackedCandidateMuonSelectorProducer (HI re-miniAOD) #31646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add muon ID selectors for packed candidate collections #30253

Add muon ID selectors for packed candidate collections #30253

stahlleiton commented Jun 15, 2020 •

edited

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

jpata Jun 15, 2020

stahlleiton Jun 21, 2020

santocch commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 •

edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jul 1, 2020 •

edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

slava77 commented Jul 3, 2020

santocch commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

slava77 commented Jul 3, 2020

silviodonato commented Jul 3, 2020

Add muon ID selectors for packed candidate collections #30253

Add muon ID selectors for packed candidate collections #30253

Conversation

stahlleiton commented Jun 15, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

jpata Jun 15, 2020

Choose a reason for hiding this comment

stahlleiton Jun 21, 2020

Choose a reason for hiding this comment

santocch commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 • edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jul 1, 2020 • edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

slava77 commented Jul 3, 2020

santocch commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

slava77 commented Jul 3, 2020

silviodonato commented Jul 3, 2020

stahlleiton commented Jun 15, 2020 •

edited

cmsbuild commented Jun 17, 2020 •

edited

cmsbuild commented Jul 1, 2020 •

edited