New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits #3026
Conversation
…etGenerator to use SeedingLayerSetsHits
All callers have been migrated to use the SeedingLayerSetsHits variant. Removing the method with this signature allows further TrackingRecHit rework.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X. Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits It involves the following packages: RecoTracker/Configuration @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
+1 |
+1 for #3026 ea073f3 |
Reco -- Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits
Migrate SpecialSeedGenerators still using SeedingLayerSetsBuilder to use SeedingLayerSetsHits. These generators are
The migration allows removal of
TrackingRegion::hits(..., const ctfseeding::SeedingLayer*)
method since nobody calls it anymore, simplifying the TrackingRecHit rework.There should be no effect on physics.