Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits #3026

Merged
merged 7 commits into from Mar 31, 2014

Conversation

makortel
Copy link
Contributor

Migrate SpecialSeedGenerators still using SeedingLayerSetsBuilder to use SeedingLayerSetsHits. These generators are

  • BeamHaloPairGenerator
  • GenericPairGenerator
  • GenericTripletGenerator
  • SimpleCosmicBONSeeder

The migration allows removal of TrackingRegion::hits(..., const ctfseeding::SeedingLayer*) method since nobody calls it anymore, simplifying the TrackingRecHit rework.

There should be no effect on physics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits

It involves the following packages:

RecoTracker/Configuration
RecoTracker/SpecialSeedGenerators
RecoTracker/TkTrackingRegions
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Mar 27, 2014

+1

@civanch
Copy link
Contributor

civanch commented Mar 27, 2014

+1

@slava77
Copy link
Contributor

slava77 commented Mar 31, 2014

+1

for #3026 ea073f3
tested in CMSSW_7_1_X_2014-03-28-1400
(test area sign330 includes pulls 3026-3037-3043-3046-3062-3080 and a cherry-pick of 3095)
no regressions as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 31, 2014
Reco -- Migrate remaining SpecialSeedGenerators to SeedingLayerSetsHits
@ktf ktf merged commit f829d63 into cms-sw:CMSSW_7_1_X Mar 31, 2014
@makortel makortel deleted the specialSeedGenerators branch October 20, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants