change boost::noncopyable for standard alternatives

[camolezi]

PR description:

Removed the boost::noncopyable inheritance, and deleted copy constructor and copy operation instead.
The code should have the same behavior.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30263/16185

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

CommonTools/Utils
DataFormats/Common
FWCore/ParameterSet
SimMuon/CSCDigitizer

@perrotta, @smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks.
@makortel, @rovere, @jhgoh, @dildick, @wddgit, @ptcox, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7113/console Started: 2020/06/16 21:03

[cmsbuild]

+1
Tested at: d0c3fbf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2a0e1/7113/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[makortel]

I'd prefer the following order

Suggested change

	ParameterSetIdConverter const& parameterSetIdConverter() const { return parameterSetIdConverter_; }
	ParameterSetConverter(const ParameterSetConverter&) = delete;
	ParameterSetConverter& operator=(const ParameterSetConverter&) = delete;
	ParameterSetConverter(const ParameterSetConverter&) = delete;
	ParameterSetConverter& operator=(const ParameterSetConverter&) = delete;
	ParameterSetIdConverter const& parameterSetIdConverter() const { return parameterSetIdConverter_; }

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2a0e1/7113/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778754
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7141/console Started: 2020/06/17 15:08

[cmsbuild]

+1
Tested at: e644d73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2a0e1/7141/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2a0e1/7141/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778757
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[makortel]

+1

[civanch]

+1

[perrotta]

+1

• Technical
• Jenkins tests pass

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1