Reduce boost dependency in PhysicsTools/NanoAOD

[camolezi]

PR description:

Changed boost::ptr_vector for std::vector<std::unique_ptr<>>
The code should have the same behavior.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30273/16202

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

isn't this worse performance-wise?
here all pointers are owned by the owner of the vector, so there's no need of reference counting or carrying around a custom deleter.
A plain vector<Variable *> could have been sufficient for all purposes except that it would have needed extra code in the destructor and the copy & move operators (and require a few more derefercing in the access), so I had used boost.
If boost is disfavoured, shouldn't be vector<unique_ptr> the right thing instead, to avoid the added overheads?

[camolezi]

isn't this worse performance-wise?
here all pointers are owned by the owner of the vector, so there's no need of reference counting or carrying around a custom deleter.
A plain vector<Variable *> could have been sufficient for all purposes except that it would have needed extra code in the destructor and the copy & move operators (and require a few more derefercing in the access), so I had used boost.
If boost is disfavoured, shouldn't be vector<unique_ptr> the right thing instead, to avoid the added overheads?

Yeah, you're right. Probably a unique_ptr is better in this situation.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30273/16231

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #30273 was updated. @cmsbuild, @santocch, @fgolf, @peruzzim can you please check and sign again.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-18-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7188/console Started: 2020/06/18 19:39

[cmsbuild]

+1
Tested at: b33028a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6ebe8/7188/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6ebe8/7188/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[silviodonato]

Any objections @peruzzim @santocch ?

[silviodonato]

merge
@santocch @peruzzim

[santocch]

+1