Phase2-hgx246 Read in flat file data using xml files for HGCal

[bsunanda]

PR description:

Read in flat file data from the xml files for HGCal

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30274/16203

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Geometry/HGCalCommonData/src/HGCalParametersFromDD.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30274/16203/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30274/16203/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30274/16204

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Geometry/HGCalCommonData/src/HGCalParametersFromDD.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7144/console Started: 2020/06/17 16:43

[cmsbuild]

+1
Tested at: a19e8b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a7e6e/7144/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30274/16259

• This PR adds an extra 96KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Geometry/HGCalCommonData/src/HGCalParametersFromDD.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Geometry/HGCalCommonData/test/python/testHGCalParametersDDD_cfg.py modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294

[cmsbuild]

Pull request #30274 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-18-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7196/console Started: 2020/06/19 04:56

[cmsbuild]

+1
Tested at: 6ba5887
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a7e6e/7196/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a7e6e/7196/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

+1

[bsunanda]

@kpedro88 Could you please approve this PR?

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1