Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare consumes in HLT related packages in FastSimulation #3028

Merged
merged 1 commit into from Mar 26, 2014
Merged

Declare consumes in HLT related packages in FastSimulation #3028

merged 1 commit into from Mar 26, 2014

Conversation

perrotta
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_1_X.

Declare consumes in HLT related packages in FastSimulation

It involves the following packages:

FastSimulation/CaloRecHitsProducer
FastSimulation/Tracking

@cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

Thanks Andrea. Are you doing any other consumes declaration? I like to hear about that to avoid double work. I'm currently introducing all the necessary consumes declarations. Luckily there was not much overlap between what you did and what I already did.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@perrotta
Copy link
Contributor Author

Hi Lukas.

No, I don't have anything else queued, about fatsim at least.

This PR is just intendend to start complying with the latest
consumes() migrations requested for HLT, see
https://hypernews.cern.ch/HyperNews/CMS/get/hlt/3467/2.html

A.

lveldere notifications@github.com ha scritto:

+1

Thanks Andrea. Are you doing any other consumes declaration? I like
to hear about that to avoid double work. I'm currently introducing
all the necessary consumes declarations. Luckily there was not much
overlap between what you did and what I already did.

Reply to this email directly or view it on GitHub:
#3028 (comment)

This message was sent using IMP, the Internet Messaging Program.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 26-Mar-2014 14:10:33 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 26-Mar-2014 14:10:33 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 26-Mar-2014 14:10:39 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 26-Mar-2014 14:10:45 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3028/651/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@perrotta
Copy link
Contributor Author

Nothing to do with this pull request!

The same error is already in last night IB, see e.g.
https://cmssdt.cern.ch/SDT/cgi-bin//showMatrixTestLogs.py/slc5_amd64_gcc481/www/wed/7.1-wed-02/CMSSW_7_1_X_2014-03-26-0200/pyRelValMatrixLogs/run/

cmsbuild notifications@github.com ha scritto:

-1
When I ran the RelVals I found an error in the following worklfows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 26-Mar-2014 14:10:33 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS  
Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 26-Mar-2014 14:10:33 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS  
Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 26-Mar-2014 14:10:39 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS  
Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 26-Mar-2014 14:10:45 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module OscarProducer/'g4SimHits'
Exception Message:
Unable to find plugin 'BSCSensitiveDetector' in category 'CMS  
Simulation SensitiveDetectorFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3028/651/summary.html

Reply to this email directly or view it on GitHub:
#3028 (comment)

This message was sent using IMP, the Internet Messaging Program.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3028/660/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 26, 2014
@ktf
Merge pull request #3028 from perrotta/fastsimConsumesForHLT
2d4a980 
Consumes migration -- Declare consumes in HLT related packages in FastSimulation
@ktf ktf merged commit 2d4a980 into cms-sw:CMSSW_7_1_X Mar 26, 2014
@perrotta perrotta deleted the fastsimConsumesForHLT branch March 26, 2014 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fastsim-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@perrotta @cmsbuild @lveldere @ktf