added esConsumes to modules in L1Trigger/L1TGEM

[JamminJones]

PR description:

added esConsumes to 6 modules

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

This change was done under my supervision.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30281/16220

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGEM/plugins/GEMPadDigiClusterProducer.cc modified in PR(s): GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters #30169, Update valid condition for GEM pads and clusters #30115
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiProducer.cc modified in PR(s): GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters #30169, Update valid condition for GEM pads and clusters #30115
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiReader.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

L1Trigger/L1TGEM

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7157/console Started: 2020/06/17 20:35

[cmsbuild]

+1
Tested at: 75cacfa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67fa8c/7157/summary.html
CMSSW: CMSSW_11_2_X_2020-06-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67fa8c/7157/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[silviodonato]

do you have any comments @rekovic ?

[Dr15Jones]

ping

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1