DD4hep: SimTracker/TrackerMaterialAnalysis tests

[vargasa]

PR description:

Unify tests in single script, cleanup

PR validation:

cd SimTracker/TrackerMaterialAnalysis/test
$cmsRun MaterialProducer10GeVNeutrino.py
$cmsRun TrackingMaterialAnalyser_dd4hep.py PhaseI
$cmsRun TrackingMaterialAnalyser_dd4hep.py PhaseII

(edit) Migration script has been renamed in order to avoid any confusion with legacy scripts

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30282/16224

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @apsallid, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mtosi]

thanks for this update
did you update the relevant twiki ?
how could we manage the group list ?

[vargasa]

@mtosi No, I guess that won't be done until the migration is completed and old scripts removed working with DDCMS/Core. But it would be helpful if you point me to the relevant twiki

[mtosi]

https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackingPOGRecoMaterialFromGeometry
thanks

[mtosi]

https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackingPOGRecoMaterialFromGeometry
thanks

the point is that this package is currently used, in particular, one of the file you are updating
https://github.com/cms-sw/cmssw/blob/a78b4c2407b9c71a19bfcb4cb2d7833a9ae889de/SimTracker/TrackerMaterialAnalysis/test/TrackingMaterialAnalyser.py
therefore, please, provide the relevant information in the twiki

in addition, how could we make the list

cmssw/SimTracker/TrackerMaterialAnalysis/test/TrackingMaterialAnalyser.py

Line 85 in a78b4c2

groupsPh2 = cms.vstring(

?
if I would need to adjust the parametrization, is there a way to automatically group material volumes in slightly a different way ?

thanks !

[vargasa]

the point is that this package is currently used

Please double check, the file you're mentioning TrackingMaterialAnalyser.py was introduced as part of the migration, please reefer to #30125. You probably are referring to the lowercase filename which is a different file that's not being modified by this or previous migration PRs.

how could we make the list

The list shown is filtered from the xml, please see: https://cmssdt.cern.ch/lxr/source/SimTracker/TrackerMaterialAnalysis/python/trackingMaterialAnalyser_ForPhaseII_cfi.py#0015

cat ../data/dd4hep_trackingMaterialGroups_ForPhaseII.xml | grep TrackingMaterialGroup | sed -e 's/\s*//' | cut -d ' ' -f 3 | tr '=' ' ' | cut -d ' ' -f 2 | tr -d '"' | sed -e 's/\(.*\)/"\1",/'

if I would need to adjust the parametrization, is there a way to automatically group material volumes in slightly a different way?

You probably need to edit the xml files located in SimTracker/TrackerMaterialAnalysis/data/ or use the dumpFullXML*.py scripts

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30282/16280

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #30282 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[mtosi]

Please double check, the file you're mentioning TrackingMaterialAnalyser.py was introduced as part of the migration, please reefer to #30125. You probably are referring to the lowercase filename which is a different file that's not being modified by this or previous migration PRs.

opsi, thanks !

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7213/console Started: 2020/06/19 21:23

[cmsbuild]

+1
Tested at: afb1777
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edd3d0/7213/summary.html
CMSSW: CMSSW_11_2_X_2020-06-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edd3d0/7213/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778757
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1