Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepMET into NanoAOD #30291

Merged
merged 6 commits into from Aug 4, 2020
Merged

Conversation

yongbinfeng
Copy link
Contributor

@yongbinfeng yongbinfeng commented Jun 18, 2020

PR description:

The PR is to add DeepMETs into NanoAOD, following the DeepMET integration into MiniAOD here: #29764.

(And more information about DeepMET could be found from presentations in the JMET group:
https://indico.cern.ch/event/912067/contributions/3835851/ (most recent update)
https://indico.cern.ch/event/883809/contributions/3733818/ (CMS week JetMET meeting)
https://indico.cern.ch/event/854654/contributions/3594579/ (first presentation in MET meeting)
)

The PR will add 4 more variables in NanoAOD (pt and phi of DeepMETResolutionTune and DeepMETResponseTune).

If running with the past Run2 eras where DeepMETs are not saved in MiniAOD, the DeepMET producer is called and DeepMETs will be computed on the fly and saved into Nano. For the future we expect them to be already computed and saved in MiniAOD, so we use the extractions instead, in a similar way as patCaloMet.

The PR was initially made towards cms-nanoAOD. Then Andreas suggests making one here since cms-nanoAOD is out of sync.

@steggema @intrepid42

@ahinzmann @lathomas

PR validation:

test on a small sample and it works as expected. Also passed unit tests and the runTheMatrix tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30291/16242

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yongbinfeng (Yongbin Feng) for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 18, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9ba59d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3f58e/7182/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3f58e/7182/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778754
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.51 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 0.510 KiB Physics/NanoAODDQM
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Jun 24, 2020

@yongbinfeng
was this presented in a JME or Cross-POG meeting?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: bd5f160
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3f58e/8426/summary.html
CMSSW: CMSSW_11_2_X_2020-07-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3f58e/8426/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2525391
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.514 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1325.7 ): 0.510 KiB Physics/NanoAODDQM
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor

+1

@mariadalfonso
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Aug 3, 2020
@slava77
Copy link
Contributor

slava77 commented Aug 3, 2020

+1

for #30291 bd5f160

  • updates since the last signoff for 00b0809 were in nanoAOD PhysicsTools/NanoAOD/python/met_cff.py, not affecting reco category files/execution

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit a0b0c7d into cms-sw:master Aug 4, 2020
@santocch
Copy link

santocch commented Aug 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants