Improve if condition to identify a Process PSet in HLTConfigProvider #30297
Conversation
SwitchProducer PSet contains an untracked @process_name, and the
getParameter("@processName") leads to an exception with that PSet.
Improve the check to check for a tracked string, and also require that
the PSet has a tracked @paths to reduce further chances of accepting
unexpected PSet.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30297/16252
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: HLTrigger/HLTcore @cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
SwitchProducer PSet contains an untracked
@process_name(added in #29435), and thegetParameter("@processName")inHLTConfigProvider? leads to an exception with that PSet. This PR proposes to improve the condition to check for a tracked string, and also require that the PSet has a tracked@paths` to reduce further chances of accepting unexpected PSets.Fixes the failures in 4.53, 136.731, 136.793, 136.874 reported in #27983 (comment).
PR validation:
Workflow 4.53 runs on top of CMSSW_11_1_X_2020-06-17-1100+#27983+the commit in this PR