Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 2018 HEfail GT and correct GT naming [11_1_X] #30299

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This is a trivial backport of PR #30286.

It corrects the 2018 realistic HEfail GT so that it differs from the standard 2018 realistic scenario only by the HCAL tags needed to simulate the failure of HEM15 and HEM16:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_upgrade2018_realistic_v1/111X_upgrade2018_realistic_HEfail_v1

It also makes several technical changes; see the description of PR #30286 for details.

PR validation:

A technical test has been performed:

runTheMatrix.py -l limited,10424.0,7.21,11224.0,11024.2,7.4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of PR #30286. It is needed so that 110X and 111X GT queues--which have different contents for these scenarios--can be maintained independently.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_11_1_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

backport #30286

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 10424.0,7.21,11224.0,11024.2,7.4

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: a37d344
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-197b7e/7190/summary.html
CMSSW: CMSSW_11_1_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-197b7e/7190/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-197b7e/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017Design_GenSimFull+DigiFull_2017Design+RecoFull_2017Design+HARVESTFull_2017Design
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-197b7e/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-197b7e/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018Design_GenSimFull+DigiFull_2018Design+RecoFull_2018Design+HARVESTFull_2018Design
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-197b7e/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780739
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5012cc0 into cms-sw:CMSSW_11_1_X Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants