HCAL: adding MC-specific TDC plots

[abdoulline]

PR description:

As a followup of discussion here #30213
several MC-only TDC plots are added to Validation/HcalDigis

PR validation:

runTheMatrix.py -l limited OK

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30334/16337

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HcalDigis/src/HcalDigisValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

Validation/HcalDigis

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-22-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7260/console Started: 2020/06/22 23:24

[cmsbuild]

+1
Tested at: 7594e7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16c072/7260/summary.html
CMSSW: CMSSW_11_2_X_2020-06-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16c072/7260/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 13262.746 KiB( 35 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 510.111 KiB HLT/HCAL
• DQMHistoSizes: changed ( 10024.0,... ): 510.104 KiB HcalDigisV/HcalDigiTask
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

@abdoulline since Hcal Validation is running on data wf, plots are being produced empty. I guess it is fine since they are few (4-8).
However, for some MC wfs I see HB only entries or HE entries only, I am not sure if this is due to stats:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-06-22-1100+16c072/37186/dqm-histo-comparison-summary.html

[abdoulline]

Let me go into some detail:

4 MC TDC-related histos are booked always=unconditionally (whether TDC is present in certain Digi collections for certain eras with every-year-evolving HCAL detector), but they are filled or not, depending on the presence of TDC info in HCAL barrel (HB) or endcaps (HE) Digis this way:
(1) in <= 2017 (Phase0) neither HB nor HE has TDC info
(2) in 2018 era only HE Digis contain TDC info (Phase1), but leagacy HB - doesn't
(3) in Run3(2021) - both HB and HE have TDC info ( both Phase1)
(4) in Phase2 - there is no HE subdetector anymore, only HB remains (with TDC)

[jfernan2]

Thanks @abdoulline That indeed clarifies.
I only have an extra comment: for Run2 and Run3 MC, in addition 4 plots are created in
HLT / HCAL / Digis / Simulation and they seem to exactly duplicate the contents.
See workflows with a +8 in:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-06-22-1100+16c072/37186/dqm-histo-comparison-summary.html

[abdoulline]

Yes, several years ago they've cloned several HCAL Validation packages for their HLT-specific needs
#18364

...And now I recall we've had a similar discussion at the bottom of #27748 thread

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1