DT TPG for Phase-2 #30344

folguera · 2020-06-23T15:37:29Z

This commit includes all the comments received during the review of the PR #28950

folguera · 2020-06-23T15:37:53Z

This superseeds #28950

cmsbuild · 2020-06-23T15:37:53Z

The code-checks are being triggered in jenkins.

silviodonato · 2020-06-23T15:42:59Z

urgent

cmsbuild · 2020-06-23T15:43:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16360

This PR adds an extra 3476KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/BuildFile.xml modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/doc/qualities.txt modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/CandidateGroup.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/DTPattern.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/DTprimitive.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/HoughGrouping.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/InitialGrouping.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MPFilter.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MPQualityEnhancerFilter.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MPRedundantFilter.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MotherGrouping.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MuonPath.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MuonPathAnalyzer.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MuonPathAnalyzerInChamber.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MuonPathAnalyzerPerSL.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/MuonPathAssociator.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/PseudoBayesGrouping.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/RPCIntegrator.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/interface/constants.h modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/plugins/BuildFile.xml modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/plugins/CalibratedDigis.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/python/CalibratedDigis_cfi.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/python/CalibratedDigishlt_cfi.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/python/HoughGrouping_cfi.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/python/PseudoBayesGrouping_cfi.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/python/dtTriggerPhase2PrimitiveDigis_cfi.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/CandidateGroup.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/DTPattern.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/DTprimitive.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/HoughGrouping.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/InitialGrouping.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MPFilter.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MPQualityEnhancerFilter.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MPRedundantFilter.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MotherGrouping.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MuonPath.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzer.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerPerSL.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/PseudoBayesGrouping.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/src/RPCIntegrator.cc modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/primitivesPhase2Prod_over_dTDigis_and_4Dsegments_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/primitivesPhase2Prod_over_dTDigis_and_4Dsegments_cfg_withRPC.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/primitivesPhase2Prod_over_hlt_parallel_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/primitivesPhase2Prod_over_mc_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/primitivesPhase2Prod_over_unpacked_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/prod_Zmu_digis_segments_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950
- File L1Trigger/DTTriggerPhase2/test/test_primitivesPhase2Prod_over_dTDigis_and_4Dsegments_cfg.py modified in PR(s): DT TPG for Phase-2 L1T upgrade #28950

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16360/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16360/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16360/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16360/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

silviodonato · 2020-06-23T15:43:11Z

assign upgrade

silviodonato · 2020-06-23T15:55:47Z

L1Trigger/DTTriggerPhase2/test/DTTriggerPhase2Primitives.root is 3.4 MB and was not included in #28950. Did you add it on purpose? If yes, it should be moved to https://github.com/cms-data/L1Trigger-DTTriggerPhase2

kpedro88 · 2020-06-23T16:09:12Z

and then the PR should be squashed to remove the root file from the history

cmsbuild · 2020-06-23T16:10:38Z

The code-checks are being triggered in jenkins.

…ring the review of the PR28950 implement code-checks code-checks + code-format

cmsbuild · 2020-06-23T16:19:11Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16362

This PR adds an extra 3536KB to repository
Found files with invalid states:
- L1Trigger/DTTriggerPhase2/test/DTTriggerPhase2Primitives.root:
  - Added: a0ce7f8
  - Deleted: fe50eab

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16362/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30344/16362/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

folguera · 2020-06-23T16:34:09Z

PR was squashed, however I do not know what to do with these errors that appear now, if I run scram build code-format locally nothing happens.

L1Trigger/DTTriggerPhase2/interface/HoughGrouping.h

L1Trigger/DTTriggerPhase2/interface/MPQualityEnhancerFilter.h

L1Trigger/DTTriggerPhase2/interface/MPRedundantFilter.h

L1Trigger/DTTriggerPhase2/interface/MotherGrouping.h

L1Trigger/DTTriggerPhase2/src/PseudoBayesGrouping.cc

L1Trigger/DTTriggerPhase2/src/RPCIntegrator.cc

kpedro88 · 2020-06-23T16:56:17Z

-1
many original comments were not actually addressed
other issues remain
opening new PRs to escape comment history will not succeed so stop trying

cmsbuild · 2020-06-30T14:47:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a84f/7515/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2778853
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 152 log files, 16 edm output root files, 36 DQM output files

kpedro88 · 2020-06-30T21:39:57Z

please test

cmsbuild · 2020-06-30T21:40:24Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-DTTriggerPhase2#1

CMSSW_11_2_X_2020-06-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7544/console Started: 2020/06/30 23:47

cmsbuild · 2020-06-30T23:31:13Z

+1
Tested at: 5454ffe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a84f/7544/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-30T23:31:19Z

Comparison job queued.

cmsbuild · 2020-07-01T01:16:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a84f/7544/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

kpedro88 · 2020-07-01T20:47:47Z

+upgrade

rekovic · 2020-07-02T05:48:46Z

+1

rekovic · 2020-07-02T05:51:00Z

+1

cmsbuild · 2020-07-02T05:51:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-02T06:00:35Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 23, 2020

cmsbuild added code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels Jun 23, 2020

folguera mentioned this pull request Jun 23, 2020

DT TPG for Phase-2 L1T upgrade #28950

Closed

cmsbuild added code-checks-rejected upgrade-pending urgent and removed code-checks-pending labels Jun 23, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 23, 2020

DT TPG for Phase-2, this commit includes all the comments recieved du…

31995f7

…ring the review of the PR28950 implement code-checks code-checks + code-format

folguera force-pushed the DTTPG_AM_11_2_Integration branch from fe50eab to 31995f7 Compare June 23, 2020 16:19

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 23, 2020

kpedro88 reviewed Jun 23, 2020

View reviewed changes

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 1, 2020

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 2, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 2, 2020

cmsbuild merged commit dbcb187 into cms-sw:master Jul 2, 2020

This was referenced Jul 2, 2020

Added missing include to fix the ROOT IBs build errors #30496

Merged

[DataFormats/PatCandidates] Rework statics in header file. #30499

Merged

silviodonato mentioned this pull request May 12, 2021

Problem with plugin for RPC Trigger Primitive #27491

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DT TPG for Phase-2 #30344

DT TPG for Phase-2 #30344

folguera commented Jun 23, 2020 •

edited

folguera commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

silviodonato commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

folguera commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

cmsbuild commented Jun 30, 2020

kpedro88 commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

rekovic commented Jul 2, 2020

rekovic commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

silviodonato commented Jul 2, 2020

DT TPG for Phase-2 #30344

DT TPG for Phase-2 #30344

Conversation

folguera commented Jun 23, 2020 • edited

folguera commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

silviodonato commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

folguera commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

cmsbuild commented Jun 30, 2020

kpedro88 commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

rekovic commented Jul 2, 2020

rekovic commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

silviodonato commented Jul 2, 2020

folguera commented Jun 23, 2020 •

edited

cmsbuild commented Jun 30, 2020 •

edited