Allow ExternalGeneratorFilter to be pickled #30346
Conversation
The pickle module was failing to unpickle the ExternalGeneratorFilter because it uses __getattr__ in an incompatible way. Adding explicit __getstate__ __setstate__ methods avoids the problem.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30346/16367
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/Core @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The pickle module was failing to unpickle the ExternalGeneratorFilter because it uses
__getattr__in an incompatible way. Adding explicit__getstate____setstate__methods avoids the problem.PR validation:
I created a configuration using ExternalGeneratorFilter then used the pickle module to pickle and unpickle the cms.Process. Without the change the unpickling process failed, with the change it worked.