Use 'perfect forwarding' of arguments to plugins #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code could not support rvalue references in plugin constructors because the code was not using C++11 'perfect forwarding' idiom.
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
ktf
added a commit
that referenced
this pull request
Aug 13, 2013
Use 'perfect forwarding' of arguments to plugins
|
This breaks builds: @vadler @Dr15Jones @alja can you please follow this up? In the meanwhile I'll revert it. |
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Mar 16, 2015
HeppyCore looper: fix sub-file splitting boundaries
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Apr 22, 2015
disable 74X geant4
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Feb 1, 2016
added SF in vhbbobj from json files
mandrenguyen
added a commit
to mandrenguyen/cmssw
that referenced
this pull request
Nov 25, 2020
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
Validation up to 9 iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code could not support rvalue references in plugin constructors
because the code was not using C++11 'perfect forwarding' idiom.