Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes migration for the Muon HLT DQM #3040

Merged
merged 1 commit into from Mar 27, 2014

Conversation

battibass
Copy link

The Muon HLT DQM module was migrated to use consumes.

Previously "getByLabel" was called by a vector of helper class instances (HLTMuonMatchAndPlot) that could only be created at BeginRun as access to the HLT menu was needed to populate the vector.

To cope with this a container helper class (HLTMuonMatchAndPlotContainer) was added to handle "consumes" calls within the HLTMuonOfflineAnalyzer constructor as well as for handling population of the vector of HLTMuonMatchAndPlot and calls to getByToken within analyze.

A contanier helper class (HLTMuonMatchAndPlotContainer) was added to
handle consumes calls within the HLTMuonOfflineAnalyzer constructor
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass for CMSSW_7_1_X.

Consumes migration for the Muon HLT DQM

It involves the following packages:

DQMOffline/Trigger

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 27, 2014
DQMOffline/Trigger -- Consumes migration for the Muon HLT DQM
@nclopezo nclopezo merged commit 3fb5781 into cms-sw:CMSSW_7_1_X Mar 27, 2014
@battibass battibass deleted the muonHltDqmConsumes branch December 10, 2014 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants