Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT Geometry Update #3042

Merged
merged 2 commits into from Mar 28, 2014
Merged

Conversation

skaplanhex
Copy link
Contributor

Update placement of sensors to account for change in PLTBCM volume. Also updates pltsens.xml to account for pixelization.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @skaplanhex (Steven Kaplan) for CMSSW_7_1_X.

PLT Geometry Update

It involves the following packages:

Geometry/ForwardCommonData
Geometry/ForwardSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Mar 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

@skaplanhex
Hi Steven,
This pull request is unmergeable. Could you please rebase it?
You can see instructions here:
http://cms-sw.github.io/cmssw/tutorial-forward-port.html

@skaplanhex
Copy link
Contributor Author

@nclopezo
Hi David,

Did this fix the issue? Thanks!

@cmsbuild
Copy link
Contributor

Pull request #3042 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@skaplanhex
Copy link
Contributor Author

Sorry, did the rebase (hopefully it works now!)

@cmsbuild
Copy link
Contributor

Pull request #3042 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@skaplanhex
Copy link
Contributor Author

Hi,

I finally heard back from Rob Loos, and it turns out there are some changes I need to make. I will do another commit soon; I apologize for all the last minute changes!

@ianna
Copy link
Contributor

ianna commented Mar 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@skaplanhex
Copy link
Contributor Author

Sorry to keep changing. I implemented the changes I received from Rob Loos at CERN into this commit.

@cmsbuild
Copy link
Contributor

Pull request #3042 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@ianna
Copy link
Contributor

ianna commented Mar 28, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 28, 2014
@nclopezo nclopezo merged commit d0c39d9 into cms-sw:CMSSW_7_1_X Mar 28, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants