Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merger producer with Duplicate Removal Backport from CMSSW_11 #30424

Merged
merged 1 commit into from Jun 27, 2020

Conversation

laurenhay
Copy link
Contributor

Unique Merger 10_6_5 pull request:

PR description:

A new merger is cloned starting from the original Merger producer: it allows merging without duplicates and provides sorted collections, for future usage in some JME workflows.

PR validation:

These are new files; they effect no existing workflows. These files have been tested on the NanoAODJMAR workflows and are working as intended.
Test workflow is:

cmsrel CMSSW_10_6_X_2020-06-19-2300   
cd CMSSW_10_6_X_2020-06-19-2300/src/
git cms-init
git cms-addpkg PhysicsTools/NanoAOD
git cms-merge-topic laurenhay:uniquemerger_10_6_X
git clone https://github.com/cms-jet/NanoAODJMAR.git PhysicsTools/NanoAODJMAR
scram b -j 10
cd PhysicsTools/NanoAODJMAR/test
cmsRun nano106X_on_mini106X_2017_mc_NANO.py

If this PR is a backport please specify the original PR and why you need to backport that PR:

This merger has already been integrated into CMSSW_11 (see pull requests #29550 and #30251). We need to backport to CMSSW_10_6_X since the mentioned NanoAODJMAR is based upon NanoAODv6 and according to XPOG recommendations should be run in CMSSW_10_6_5.

@rappoccio

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@laurenhay laurenhay closed this Jun 25, 2020
@laurenhay laurenhay reopened this Jun 25, 2020
@laurenhay laurenhay changed the base branch from master to CMSSW_10_6_X June 25, 2020 18:53
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30424/16498

  • This PR adds an extra 16KB to repository

@cmsbuild cmsbuild removed this from the CMSSW_11_2_X milestone Jun 25, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020

A new Pull Request was created by @laurenhay for CMSSW_10_6_X.

It involves the following packages:

CommonTools/CandAlgos
CommonTools/UtilAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@laurenhay laurenhay marked this pull request as ready for review June 25, 2020 19:43
@slava77
Copy link
Contributor

slava77 commented Jun 25, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: b2fcf5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a1e6f/7413/summary.html
CMSSW: CMSSW_10_6_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a1e6f/7413/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212264
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211928
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 26, 2020

backport of #29550
backport of #30251

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2020

+1

for #30424 b2fcf5f

  • the backport is correct: the version of the three new file in this PR is the same as in the (merged) master version
    • the new merger instances are used for analysis at this point (or/and for nanoAOD)
  • jenkins tests pass (compiles; the new code did not run in the tests)

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e91615a into cms-sw:CMSSW_10_6_X Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants