Allow pixel template ID = 0 to ensure backwards compatibility

[OzAmram]

This PR is very small bugfix. PR #28945 introduced a very small backwards compatabibility issue that was pointed out in this hypernews thread. A config to reproduce the crash is here

The issue is that there was one pixel template that was used for 0T conditions in 2017 that had a template ID of 0. The PR #28945 synced with standalone calibration code that used ID = 0 to signify a special calibration template and bypass some of the regular functionality. So this meant this specific template would no longer be used correctly. This PR makes the very small change of requiring these calibration templates to have a negative ID instead of 0. There should be no changes in anything except for things with GT's containing this specific payload (SiPixelTemplateDBObject_phase1_0T_mc_v2).

@mmusich @tvami @pmaksim1 @slava77 @perrotta

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30435/16537

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/src/SiPixelTemplateReco2D.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @dkotlins, @gpetruc, @ebrondol, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-26-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7445/console Started: 2020/06/26 22:37

[slava77]

There should be no changes in anything except for things with GT's containing this specific payload (SiPixelTemplateDBObject_phase1_0T_mc_v2).

are there some current autoCond GTs with this payload?

[mmusich]

@slava77

are there some current autoCond GTs with this payload?

Basically all pixel phase-1 Global Tags (>=2017).

[cmsbuild]

+1
Tested at: b24e2c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c53098/7445/summary.html
CMSSW: CMSSW_11_2_X_2020-06-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c53098/7445/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778861
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #30435 b24e2c5

• code changes are in line with the PR description; the change affects only 0T setup
• jenkins tests pass and comparisons with the baseline show no differences (apparently we do not have a default workflow with 0T in these tests)
  • relying on DPG tests for correctness of the change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1