Protection for extrapolation of laser corrections (reload PR #30254)

[fcouderc]

reload of PR #30254

PR description:

add extra parameter to protect for extrapolation of laser corrections.

if t > t3 + dt : t = t3+dt

PR validation:

addOnTests.py
runTheMatrix.py was not re-run, but was working perfectly for the last PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30439/16547

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30439/16547/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30439/16547/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30439/16549

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fcouderc for master.

It involves the following packages:

CalibCalorimetry/EcalLaserCorrection

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@rchatter, @mmusich, @tocheng, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

@fcouderc In case you were unaware, you may find the instructions for rebasing and porting features useful.

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-27-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7460/console Started: 2020/06/27 18:05

[cmsbuild]

+1
Tested at: f99a007
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6569bc/7460/summary.html
CMSSW: CMSSW_11_2_X_2020-06-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6569bc/7460/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778861
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[fcouderc]

All failures explained in PR#30254.

[fcouderc]

FYI @Martin-Grunewald

[Martin-Grunewald]

Thanks! And no HLT signature needed anymore.

[Martin-Grunewald]

Hi,

Now with fillDescriptions, you no longer need the explicit cfi file in the ../python directory. Upon compilation of the c++ code with scram, a cfi file will be generated from fillDescriptions and placed into ../cfipython, accessible thru the same path CalibCalorimetry.EcalLaserCorrection.EcalLaserCorrectionService_cfi

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[fcouderc]

FYI @blenzi