SimGeneral/Debugging: add MTD to the digi dump

[fabiocos]

PR description:

Simple update of the SimDigiDumper class, to be used for visual inspection of DIGI collections content, where the MTD digi collections (BTL and ETL) are added and printed, if present.

PR validation:

Used in debugging #30340 , here is the dump for a digi in test wf. 23234.0 :

Barrel Timing Layer, digi multiplicity = 539
1652623911
[0] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 12 Row: 0 Column: 13 Raw Flag=0x3 Raw Data=0x3ffffc0c
[1] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 11 Row: 0 Column: 13 Raw Flag=0x3 Raw Data=0x3ffffc0b
1652626726
[0] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 43 Row: 2 Column: 12 Raw Flag=0x3 Raw Data=0x3ffffc2b
[1] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 45 Row: 2 Column: 12 Raw Flag=0x3 Raw Data=0x3ffffc2d
1652630315
[0] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 4 Row: 1 Column: 14 Raw Flag=0x3 Raw Data=0x3ffffc04
[1] THR: 1 Mode: 0 ToA2: 978 ToA: 948 Data: 5 Row: 1 Column: 14 Raw Flag=0x2 Raw Data=0x3d2ed005
1652632077
[0] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 10 Row: 1 Column: 4 Raw Flag=0x3 Raw Data=0x3ffffc0a
[1] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 10 Row: 1 Column: 4 Raw Flag=0x3 Raw Data=0x3ffffc0a
1652632080
[0] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 6 Row: 1 Column: 5 Raw Flag=0x3 Raw Data=0x3ffffc06
[1] THR: 1 Mode: 1 ToA2: 1023 ToA: 1023 Data: 6 Row: 1 Column: 5 Raw Flag=0x3 Raw Data=0x3ffffc06
1652635414
[0] THR: 1 Mode: 0 ToA2: 890 ToA: 853 Data: 8 Row: 1 Column: 7 Raw Flag=0x2 Raw Data=0x37ad5408
[1] THR: 1 Mode: 0 ToA2: 891 ToA: 847 Data: 8 Row: 1 Column: 7 Raw Flag=0x2 Raw Data=0x37bd3c08
(...)
Endcap Timing Layer, digi multiplicity = 206
1661011072
[0] (row,col) : (10,1) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x2500000
[1] (row,col) : (10,1) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x2500000
[2] (row,col) : (10,1) THR: 1 Mode: 0 ToA: 1027 Data: 10 Raw=0x8254030a
[3] (row,col) : (10,1) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x2500000
[4] (row,col) : (10,1) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x2500000
1661011584
[0] (row,col) : (45,18) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x25680000
[1] (row,col) : (45,18) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x25680000
[2] (row,col) : (45,18) THR: 1 Mode: 0 ToA: 896 Data: 12 Raw=0xa56b800c
[3] (row,col) : (45,18) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x25680000
[4] (row,col) : (45,18) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x25680000
1661011712
[0] (row,col) : (39,17) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x23380000
[1] (row,col) : (39,17) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x23380000
[2] (row,col) : (39,17) THR: 1 Mode: 0 ToA: 885 Data: 9 Raw=0xa33b7509
[3] (row,col) : (39,17) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x23380000
[4] (row,col) : (39,17) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x23380000
1661011712
[0] (row,col) : (6,19) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x26300000
[1] (row,col) : (6,19) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x26300000
[2] (row,col) : (6,19) THR: 1 Mode: 0 ToA: 927 Data: 28 Raw=0xa6339f1c
[3] (row,col) : (6,19) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x26300000
[4] (row,col) : (6,19) THR: 0 Mode: 0 ToA: 0 Data: 0 Raw=0x26300000
(...)

It does not affect any production workflow or unit test.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30441/16551

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimGeneral/Debugging/test/SimDigiDumper.cc modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/SimDigiDumper.h modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/runSimDigiDumper_cfg.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30441/16551/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30441/16551/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30441/16552

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimGeneral/Debugging/test/SimDigiDumper.cc modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/SimDigiDumper.h modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/runSimDigiDumper_cfg.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

SimGeneral/Debugging

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30441/16553

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimGeneral/Debugging/test/SimDigiDumper.cc modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/SimDigiDumper.h modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
  • File SimGeneral/Debugging/test/runSimDigiDumper_cfg.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340

[cmsbuild]

Pull request #30441 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-28-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7461/console Started: 2020/06/28 15:15

[cmsbuild]

+1
Tested at: df6536e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1706b/7461/summary.html
CMSSW: CMSSW_11_2_X_2020-06-28-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1706b/7461/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778864
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[fabiocos]

@icosivi @casarsa FYI

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1