PPS: re-alignment module #30452
PPS: re-alignment module #30452
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30452/16584
|
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: RecoPPS/Local @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30452/16648
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30452/16657 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR adds a convenience module which can apply (some) alignment changes directly to lite local tracks, a format that is available in miniAOD. The motivation is to have an effective tool to check alignment updates without the burden of accessing AOD files (often on tape). The alignment updates compatible with this new module are limited to RP shifts - such changes are equivalent to shifts of reconstructed tracks.
This new module will NOT be used in any central workflow, thus absolutely no changes are expected. This new module is intended for private use by experts.
PR validation:
Validation files can be found in "RecoPPS/Local/test/re_alignment". There are several alignment files: full (with complete alignment) and also split into two components (base and corr). Standard PPS reco is made with the "full" (black) and "base" (blue) alignment. Then, the re-alignment is run on top of "base" results with "corr" alignment (red dashed). The plot below shows histograms of reconstructed track positions: As expected black and red-dashed histograms overlap and the blue histogram is misaligned.
