Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory cleanup -- rebase #3046

Merged
merged 17 commits into from Mar 31, 2014
Merged

Trajectory cleanup -- rebase #3046

merged 17 commits into from Mar 31, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Mar 27, 2014

Rebase of #3010.

Pure technical changes to cleanup Trajectory and TrackCandidate memory churn.
Still a lot can be done (for instance in Conversion code).
More will be done once fitters will be migrated to use standard TRH instead of TTRH.

In any case it is a sort of lost battle as classes whose objects are stored in vector in the event cannot be made non-copiable due to Reflex. Will try again with Root6.

No regression expected.
No regression observed.

@ktf
Copy link
Contributor Author

ktf commented Mar 27, 2014

@VinInn this is a rebase of your pull request. I did it via:

git cms-merge-topic 3010
git rebase -i

in a CMSSW_7_1_X IB. Most likely in your workarea it's enough to do:

git fetch official-cmssw # to update.
git rebase -i official-cmssw/CMSSW_7_1_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Rebase #3010

It involves the following packages:

DQM/BeamMonitor
DataFormats/Common
DataFormats/TrackCandidate
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoLocalTracker/SiPixelRecHits
RecoMuon/CosmicMuonProducer
RecoMuon/StandAloneTrackFinder
RecoMuon/TrackingTools
RecoTracker/CkfPattern
RecoTracker/SingleTrackPattern
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
TrackingTools/PatternTools
TrackingTools/TrackFitters
TrackingTools/TrackRefitter
TrackingTools/TrajectoryState

@ojeda, @danduggan, @rovere, @cmsbuild, @anton-a, @Dr15Jones, @deguio, @slava77, @Degano, @ktf, @thspeer, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 27, 2014

Giulio, please keep the subject of the original PR in the subject of this one.

@ktf ktf changed the title Rebase #3010 Trajectory cleanup -- rebase Mar 27, 2014
@VinInn
Copy link
Contributor

VinInn commented Mar 27, 2014

description from original #3010
Pure technical changes to cleanup Trajectory and TrackCandidate memory churn.
Still a lot can be done (for instance in Conversion code).
More will be done once fitters will be migrated to use standard TRH instead of TTRH.

In any case it is a sort of lost battle as classes whose objects are stored in vector in the event cannot be made non-copiable due to Reflex. Will try again with Root6.

No regression expected.
No regression observed.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 27, 2014

+1

@slava77
Copy link
Contributor

slava77 commented Mar 31, 2014

+1

for #3046 6e83ff5

tested in CMSSW_7_1_X_2014-03-28-1400
(test area sign330 includes pulls 3026-3037-3043-3046-3062-3080 and a cherry-pick of 3095)
no regressions as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 31, 2014
Tracking speedup -- Trajectory cleanup
@ktf ktf merged commit 4d9e8fe into cms-sw:CMSSW_7_1_X Mar 31, 2014
@ktf ktf deleted the fix-3010 branch June 4, 2014 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants