Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made statics const #3047

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer flagged these as not being thread-unsafe because
of the use of a non-const statc. In this particular case the static
could be made const without a problem.

The static analyzer flagged these as not being thread-unsafe because
of the use of a non-const statc. In this particular case the static
could be made const without a problem.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made statics const

It involves the following packages:

PhysicsTools/PatUtils

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

@vadler @Degano @monttj ping?

@vadler
Copy link

vadler commented Mar 31, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 31, 2014
…sPatUtils

Multithreading -- Made statics const
@ktf ktf merged commit 01d0d34 into cms-sw:CMSSW_7_1_X Mar 31, 2014
@Dr15Jones Dr15Jones deleted the makeStaticsConstInPhysicsToolsPatUtils branch April 4, 2014 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants