Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 111X of ESGetToken update in L1T O2O producer #30494

Merged
merged 8 commits into from Jul 7, 2020

Conversation

gekobs
Copy link
Contributor

@gekobs gekobs commented Jul 1, 2020

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of PR#30155 to CMSSW_11_1_X

This PR updates L1T O2O producers to use ESGetToken.

The backport is needed as since CMSSW_11_0_X, which incorporates PR#28223 ESProducers need to use ESGetToken to access data from EventSetup.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

A new Pull Request was created by @gekobs (agzecchinelli) for CMSSW_11_1_X.

It involves the following packages:

CondTools/L1TriggerExt
L1TriggerConfig/L1TConfigProducers

@ggovi, @rekovic, @benkrikler, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@boudoul
Copy link
Contributor

boudoul commented Jul 3, 2020

Dear @ggovi, @rekovic, @benkrikler , @silviodonato - I would be good if this backport could be considered in order to switch to 11_1_X at P5, thanks -

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

+1
Tested at: 96af791
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-026995/7650/summary.html
CMSSW: CMSSW_11_1_X_2020-07-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-026995/7650/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jul 6, 2020

+1

@boudoul
Copy link
Contributor

boudoul commented Jul 7, 2020

Hi @rekovic , we are missing your signature , could you please sign ? Thanks

@rekovic
Copy link
Contributor

rekovic commented Jul 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants